fix(model_names, X): updates to ApiSimulation and ApiModel#79
Merged
Conversation
* filter interface models from model_names * slice x array by nodetouser.size to avoid IndexErrors from MAW heads
pya
reviewed
May 1, 2025
Contributor
pya
left a comment
pya
left a comment
There was a problem hiding this comment.
Channing:
if name.startswith("GWTIM") or name.startswith("GWFIM") or name.startswith("GWEIM"):to
if any(name.startswith(prefix) for prefix in ["GWTIM", "GWFIM", "GWEIM"]):makes the line shorter. I also allows to move the list of unwanted names to a variable , i.e. interface_model_names = ["GWTIM", "GWFIM", "GWEIM"] :
if any(name.startswith(prefix) for prefix in interface_model_names):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Closes #71